Update CODEOWNERS for Git submodules #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #725 the Git submodules directories were added to CODEOWNERS to try and reduce PR review noise. However, the languages team alias was still requested for review in #733 and #744. I suspect this might be due to the trailing slash for these entries in CODEOWNERS - since if you look at the diff view for one of those PRs, they are unsurprisingly tracked as a flat file with a reference, not a directory, eg: https://patch-diff.githubusercontent.com/raw/heroku/buildpacks-jvm/pull/733.diff
edmorley
added
the
skip changelog
Malax
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #725 the Git submodules directories were added to CODEOWNERS to try and reduce PR review noise.
However, the languages team alias was still requested for review in #733 and #734.
I suspect this might be due to the trailing slash for these entries in CODEOWNERS - since if you look at the diff view for one of those PRs, they are unsurprisingly tracked as a flat file with a reference, not a directory, eg:
https://patch-diff.githubusercontent.com/raw/heroku/buildpacks-jvm/pull/733.diff