Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle additional variations of rate limit error messages #182

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

edmorley
Copy link
Member

There were another two variations of a rate limit error message that previously weren't being detected as an error related to exceeding the rate limit. This meant Hatchet wouldn't perform request backoff, which would result in cascading failures.

Fixes #176.

There were another two variations of a rate limit error message
that previously weren't being detected as an error related to
exceeding the rate limit. This meant Hatchet wouldn't perform
request backoff, which would result in cascading failures.

Fixes #176.
@edmorley edmorley self-assigned this Jan 27, 2021
@schneems
Copy link
Contributor

Thanks!

@schneems schneems merged commit 2222c4a into main Jan 29, 2021
@schneems schneems deleted the edmorley/more-http429-cases branch January 29, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hatchet not detecting rate limit being hit in some cases
2 participants