Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app.run fixes #58

Merged
merged 3 commits into from
Mar 8, 2019
Merged

app.run fixes #58

merged 3 commits into from
Mar 8, 2019

Commits on Mar 8, 2019

  1. allow 'heroku run' options to have no value 

    by passing nil
    @dzuelke
    dzuelke committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    15453f6 View commit details
    Browse the repository at this point in the history

  2. order 'heroku run' options before command 

    and separate using double dash

avoids any possible conflicts between `heroku run` options and program options, e.g. when running `ls -a foo`

this also means it's no longer necessary to shell-escape the command (which would previously turn it into a single string, which the Heroku CLI then unpacked again)
    @dzuelke
    dzuelke committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    59f76d4 View commit details
    Browse the repository at this point in the history

  3. always make "heroku run" return exit code 

    can be tested afterwards using $?.exitstatus
    @dzuelke
    dzuelke committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    bda6d9b View commit details
    Browse the repository at this point in the history