Document that this buildpack is only for Heroku Redis 5 and older #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since with Heroku Redis 6 and newer, the built-in TLS support should be used instead: https://devcenter.heroku.com/articles/securing-heroku-redis
|
@beanieboi Could I have a review? Also, I wonder if in a future PR, this buildpack should do a build-time check for a |
|
sorry, this went under my radar. approved. |
beanieboi
approved these changes
Jan 4, 2022
edmorley
added a commit
to heroku/base-images
that referenced
this pull request
Mar 21, 2024
Since: - `heroku-buildpack-pgbouncer` hasn't used stunnel since 2018: heroku/heroku-buildpack-pgbouncer#104 - Redis 6 and newer support native TLS, making `heroku-buildpack-redis` redundant: heroku/heroku-buildpack-redis#40 (The buildpack can be sunset now that old Redis instances have been shut down) - If any other less common use-case needs stunnel, they can install it using APT. - It reduces the run and build image sizes by 17 MB, and in a CNB world image size is a much bigger concern, so we need to be more selective about what packages we include. - Once Heroku-24 GAs we can't remove packages (since it will break backwards compatibility given stack rebasing), however, we can add packages - so we should err on the side of trying out removing packages now. Before: ``` -----> Size breakdown... heroku/heroku:24 441MB heroku/heroku:24-build 1.13GB ``` After: ``` -----> Size breakdown... heroku/heroku:24 424MB heroku/heroku:24-build 1.11GB ``` Towards #266. GUS-W-15159536.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since with Heroku Redis 6 and newer, the built-in TLS support should be used instead:
https://devcenter.heroku.com/articles/securing-heroku-redis