Switch to heroku/builder:22 in docs and tests
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it supersedes `heroku/buildpacks:20`: https://github.com/heroku/builder#heroku-builder-images Whilst updating the example build output in the README, I noticed that the specified commands were incorrect (eg wrong buildpack path), so those have been fixed. In addition, I've switched the hello world example to use the wildcard stack, since the code is not stack-specific, and it will save us having to remember to update it in the future. Lastly, updating the Ruby example buildpack to `heroku/builder:22` revealed that the buildpack was actually broken and relying on system Ruby, so that buildpack has been excluded from using the new builder until that is resolved: #398
edmorley
added
documentation
Malax
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it supersedes
heroku/buildpacks:20:https://github.com/heroku/builder#heroku-builder-images
Whilst updating the example build output in the README, I noticed that the specified commands were incorrect (eg wrong buildpack
--path), so those have been fixed. In addition, I've switched the hello world example to use the wildcard stack, since the code is not stack-specific, and it will save us having to remember to update it in the future.Lastly, updating the Ruby example buildpack to
heroku/builder:22revealed that the buildpack was actually broken and relying on system Ruby, so that buildpack has been excluded from using the new builder until that is resolved (#398).