Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unless attribute to weave::run type uses image, rather than container for a docker inspect based condition #7

Closed
hesco opened this issue Oct 13, 2014 · 1 comment
Assignees
Labels

Comments

@hesco
Copy link
Owner

hesco commented Oct 13, 2014

Following error results from a weave run which duplicates an already running docker container. The unless => attribute is failing because I am using the $image, rather than the $container_name in the docker inspect condition assigned to unless. Resolving this requires changing the interface of the weave::run defined type, breaking backward compatibility. But as only 22 folks have downloaded this so far from the forge, and the README warns that "This is alpha code and no promises are made at this early stage as to the stability of its interface, or its suitability for production use." I will bust this bug and increment a minor version number and note the caveat in the README and move on.

Error: /Stage[main]/Docker_cluster::Hosts::Dockerhost001_example_com/My_docker::Container[weave_run rt.example.com]/Weave::Run[weave run rt.example.com at 10.0.1.28/24]/Exec[weave run 10.0.1.28/24 rt]/returns: change from notrun to 0 failed: /usr/local/bin/weave run 10.0.1.28/24 -p 80:8088 --memory=1g --restart=always --net=bridge --name="rt.example.com" -h rt.example.com -v /data/usr/share/request-tracker4/rt.example.com:/usr/share/request-tracker4 -v /data/var/log/apache2/rt.example.com:/var/log/apache2/rt.example.com -v /data/var/log/request-tracker4/rt.example.com:/var/log/request-tracker4 -v /data/etc/apache2/rt.example.com:/etc/apache2 -v /data/etc/request-tracker4/rt.example.com:/etc/request-tracker4 rt returned 1 instead of one of [0]

@hesco hesco added the bug label Oct 13, 2014
@hesco hesco self-assigned this Oct 13, 2014
@hesco hesco closed this as completed Oct 13, 2014
@hesco hesco reopened this Oct 13, 2014
hesco added a commit that referenced this issue Oct 13, 2014
…E CHANGE

This adds a new $host parameter to the interface of this defined type.
Necessary to fix bug in unless => attribute
@hesco
Copy link
Owner Author

hesco commented Oct 13, 2014

Resolved with publication of: https://forgeapi.puppetlabs.com/v3/files/hesco-weave-0.7.2.tar.gz

@hesco hesco closed this as completed Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant