Add Whilelisting of callsigns; Enable disallow functionality #60
Conversation
|
I will note that I have live tested it: |
|
This feature looks very interesting! |
|
Hi, as you can see from the automatic test runs by Travis, the behaviour changes so that the existing tests fail. Please run the test suite (cd tests; make test) and fix any obvious issues. The .travis.yml in the root describes the steps to install dependencies for the tests. In principle the feature looks good, but the PR should not break existing tests and use cases without careful consideration and good reasons to do so. |
|
|
||
| Separate multiple callsigns with spaces. | ||
|
|
||
| AllowLoginCall rejects logins by the specified callsign. Callsigns which |
There was a problem hiding this comment.
I think an option which rejects logins by a specific callsign should be named "Disallow" or "Reject", instead of "Allow" which would imply the opposite.
There was a problem hiding this comment.
Ah, in fact this is documentation for an existing option, DisallowLoginCall. :)
|
|
||
| AllowLoginCall P1RAT* P?ROT* | ||
|
|
||
| AllowSourceCall makes the server drop packets sent by the given source |
| @@ -402,6 +437,13 @@ int login_handler(struct worker_t *self, struct client_t *c, int l4proto, char * | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| if (disallow_unverified && !(c->validated)) { | |||
There was a problem hiding this comment.
This is not right; this breaks connections from unverified clients. They are intentionally allowed to connect, they're just not allowed to send packets. There might be some yelling if this change is done as a surprise; if you wish to propose a change like this, please do so on APRSSIG.
Sorry about not having tests and stuff. I have no real experience with C so I was very very hacky. I dunno if someone can help me with the tests and cleaning it up.