fix(firewall): wrong wording when firewall is removed from resource (#…

…812) Closes #809
hetznercloud · Jul 10, 2024 · 9017a65 · 9017a65
1 parent f6877a1
commit 9017a65
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/internal/cmd/firewall/apply_to_resource.go b/internal/cmd/firewall/apply_to_resource.go
@@ -84,7 +84,7 @@ var ApplyToResourceCmd = base.Cmd{
 		if err := s.WaitForActions(cmd, s, actions...); err != nil {
 			return err
 		}
-		cmd.Printf("Firewall %d applied\n", firewall.ID)
+		cmd.Printf("Firewall %d applied to resource\n", firewall.ID)
 
 		return nil
 	},

diff --git a/internal/cmd/firewall/apply_to_resource_test.go b/internal/cmd/firewall/apply_to_resource_test.go
@@ -43,7 +43,7 @@ func TestApplyToServer(t *testing.T) {
 
 	out, errOut, err := fx.Run(cmd, []string{"--type", "server", "--server", "my-server", "test"})
 
-	expOut := "Firewall 123 applied\n"
+	expOut := "Firewall 123 applied to resource\n"
 
 	assert.NoError(t, err)
 	assert.Empty(t, errOut)
@@ -79,7 +79,7 @@ func TestApplyToLabelSelector(t *testing.T) {
 
 	out, errOut, err := fx.Run(cmd, []string{"--type", "label_selector", "--label-selector", "my-label", "test"})
 
-	expOut := "Firewall 123 applied\n"
+	expOut := "Firewall 123 applied to resource\n"
 
 	assert.NoError(t, err)
 	assert.Empty(t, errOut)

diff --git a/internal/cmd/firewall/remove_from_resource.go b/internal/cmd/firewall/remove_from_resource.go
@@ -83,7 +83,7 @@ var RemoveFromResourceCmd = base.Cmd{
 		if err := s.WaitForActions(cmd, s, actions...); err != nil {
 			return err
 		}
-		cmd.Printf("Firewall %d applied\n", firewall.ID)
+		cmd.Printf("Firewall %d removed from resource\n", firewall.ID)
 
 		return nil
 	},

diff --git a/internal/cmd/firewall/remove_from_resource_test.go b/internal/cmd/firewall/remove_from_resource_test.go
@@ -43,7 +43,7 @@ func TestRemoveFromServer(t *testing.T) {
 
 	out, errOut, err := fx.Run(cmd, []string{"--type", "server", "--server", "my-server", "test"})
 
-	expOut := "Firewall 123 applied\n"
+	expOut := "Firewall 123 removed from resource\n"
 
 	assert.NoError(t, err)
 	assert.Empty(t, errOut)
@@ -79,7 +79,7 @@ func TestRemoveFromLabelSelector(t *testing.T) {
 
 	out, errOut, err := fx.Run(cmd, []string{"--type", "label_selector", "--label-selector", "my-label", "test"})
 
-	expOut := "Firewall 123 applied\n"
+	expOut := "Firewall 123 removed from resource\n"
 
 	assert.NoError(t, err)
 	assert.Empty(t, errOut)