Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: hcloud server create --enable-protection #488

Closed
mkarg opened this issue Jun 3, 2023 · 5 comments
Closed

Enhancement: hcloud server create --enable-protection #488

mkarg opened this issue Jun 3, 2023 · 5 comments
Assignees
@phm07
Labels
feature

Comments

@mkarg
Copy link

mkarg commented Jun 3, 2023

It is a bit tedious that a server can be built with a single command including all kinds of resource bindings like firewall, ip and volumes, but a second command is needed to enable protection (and backup).

It would be cool if there would be an --enable-protection (and --enable-backup) flag do that as the last task of hcloud server create.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the stale label Sep 2, 2023
@mkarg
Copy link
Author

mkarg commented Sep 2, 2023

It would be nice if a committer could briefly comment if such a feature would make sense.

@github-actions github-actions bot removed the stale label Sep 3, 2023
@apricote
Copy link
Member

This sounds like a good idea! @pauhull will take a stab at the implementation.

phm07 added a commit that referenced this issue Oct 18, 2023
@phm07
refactor: extract protection level parsing and changing
f207efd 
In preparation for the changes requested in #488
@phm07 phm07 mentioned this issue Oct 18, 2023
Merged
phm07 added a commit that referenced this issue Oct 18, 2023
@phm07
refactor: extract protection level parsing and changing
478107d 
In preparation for the changes requested in #488
phm07 added a commit that referenced this issue Oct 18, 2023
@phm07
refactor: extract protection level parsing and changing (#566)
09f1a4d 
In preparation for the changes requested in #488
phm07 added a commit that referenced this issue Oct 18, 2023
@phm07
feat: add --enable-protection flag to "create" commands
f3c3a0a 
As requested in #488
@phm07 phm07 mentioned this issue Oct 18, 2023
Merged
phm07 added a commit that referenced this issue Oct 18, 2023
@phm07
feat: add --enable-protection flag to "create" commands
3742239 
As requested in #488
phm07 added a commit that referenced this issue Oct 18, 2023
@phm07
feat: add --enable-protection flag to "create" commands (#567)
e313e69 
As requested in #488
phm07 added a commit that referenced this issue Oct 18, 2023
@phm07
feat(server): add --enable-backup flag to "create" command
d293c50 
As requested in #488
@phm07 phm07 mentioned this issue Oct 18, 2023
Merged
phm07 added a commit that referenced this issue Oct 19, 2023
@phm07
feat(server): add --enable-backup flag to "create" command (#568)
15adee0 
As requested in #488
@phm07
Copy link
Contributor

phm07 commented Oct 19, 2023

Implemented in #567, #568 and #570

@phm07 phm07 closed this as completed Oct 19, 2023
@mkarg
Copy link
Author

mkarg commented Oct 20, 2023

Thanks a lot, @pauhull ! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phm07 phm07

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkarg @apricote @phm07