Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatting broken when creating server with multiple networks #820

Closed
apricote opened this issue Jul 21, 2024 · 0 comments
Closed

fix: formatting broken when creating server with multiple networks #820

apricote opened this issue Jul 21, 2024 · 0 comments
Assignees
Labels

Comments

@apricote
Copy link
Member

TL;DR

Formatting of the Private Networks: list is off when multiple networks are attached.

Expected behavior

Output should have proper formatting:

Server 50678284 created
IPv4: 188.245.86.169
IPv6: 2a01:4f8:c012:56a0::1
IPv6 Network: 2a01:4f8:c012:56a0::/64
Private Networks:
	- 10.0.0.2 (foo)
	- 10.1.0.2 (bar)

Observed behavior

Second network does not have a tab prefix:

Server 50678284 created
IPv4: 188.245.86.169
IPv6: 2a01:4f8:c012:56a0::1
IPv6 Network: 2a01:4f8:c012:56a0::/64
Private Networks:
	- 10.0.0.2 (foo)
- 10.1.0.2 (bar)

Minimal working example

hcloud network create --name foo --ip-range 10.0.0.0/16
hcloud network add-subnet foo --type cloud --network-zone eu-central --ip-range 10.0.0.0/16
hcloud network create --name bar --ip-range 10.1.0.0/16
hcloud network add-subnet bar --type cloud --network-zone eu-central --ip-range 10.1.0.0/16

hcloud server create --name multiple-networks --location fsn1 --type cax11 --image ubuntu-24.04 --network foo --network bar

Log output

No response

Additional information

$ hcloud version
hcloud 1.44.0-dev
@apricote apricote added the bug label Jul 21, 2024
@jooola jooola self-assigned this Jul 24, 2024
jooola added a commit that referenced this issue Jul 25, 2024
Closes #820

Also add some more data in the mocked server calls to cover more code.
@jooola jooola closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants