fix(image): only accept numerical ids for update, delete, label #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
requested changes
Aug 14, 2024
There was a problem hiding this comment.
I agree in principal that we should get rid of deprecated behavior.
For image labels though, this is unecessary. Users can only change the labels of images with type=backup and type=snapshot. These images always have empty names, so it does not matter that you can not uniquely identify the image to be labeled through the name. Users have to pass the ID in all cases.
We can instead modify this to use GetByID().
phm07
force-pushed
the
image-architecture
branch
from
b31cb2a
to
6528f3e
Compare
phm07
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
- Coverage 59.65% 59.62% -0.04%
==========================================
Files 209 209
Lines 7701 7710 +9
==========================================
+ Hits 4594 4597 +3
- Misses 2459 2462 +3
- Partials 648 651 +3 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Aug 16, 2024
phm07
pushed a commit
that referenced
this pull request
Aug 30, 2024
🤖 I have created a release *beep* *boop* --- ## [1.47.0](v1.46.0...v1.47.0) (2024-08-30) ### Features * allow deleting rDNS entries ([#839](#839)) ([129f51d](129f51d)), closes [#814](#814) * **certificate:** allow retrying managed certificate issuance ([#847](#847)) ([0223f7d](0223f7d)) * improve datacenter describe server types readability ([#854](#854)) ([fc0002c](fc0002c)), closes [#852](#852) ### Bug Fixes * `quiet` option sometimes only working as a flag ([#846](#846)) ([f7c9ac6](f7c9ac6)) * **image:** only accept numerical ids for update, delete, label ([#844](#844)) ([7355571](7355571)) * **load-balancer:** show message if none of --server, --label-selector or --ip is set ([#849](#849)) ([2df45e0](2df45e0)) * **primary-ip:** change protection commands do not allow protection levels ([#851](#851)) ([697a87a](697a87a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Image().Get()is deprecated, we should switch to an alternative.All the modifying calls for images are only allowed for
type=backupandtype=snapshot. These types cannot have names, so the user is required to pass in an ID in anyway. The easiest alternative isImage().GetByID().