fix(primary-ip): change protection commands do not allow protection levels #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 61.49% 61.50%
=======================================
Files 238 238
Lines 8502 8504 +2
=======================================
+ Hits 5228 5230 +2
Misses 2568 2568
Partials 706 706 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Aug 28, 2024
phm07
pushed a commit
that referenced
this pull request
Aug 30, 2024
🤖 I have created a release *beep* *boop* --- ## [1.47.0](v1.46.0...v1.47.0) (2024-08-30) ### Features * allow deleting rDNS entries ([#839](#839)) ([129f51d](129f51d)), closes [#814](#814) * **certificate:** allow retrying managed certificate issuance ([#847](#847)) ([0223f7d](0223f7d)) * improve datacenter describe server types readability ([#854](#854)) ([fc0002c](fc0002c)), closes [#852](#852) ### Bug Fixes * `quiet` option sometimes only working as a flag ([#846](#846)) ([f7c9ac6](f7c9ac6)) * **image:** only accept numerical ids for update, delete, label ([#844](#844)) ([7355571](7355571)) * **load-balancer:** show message if none of --server, --label-selector or --ip is set ([#849](#849)) ([2df45e0](2df45e0)) * **primary-ip:** change protection commands do not allow protection levels ([#851](#851)) ([697a87a](697a87a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the protections level support for Primary IPs was added later, they are optional so that the command is backwards compatible. This meant that the usage validation was not working properly. This PR fixes this and adds tests.