fix: primary-ip list returns max 50 items #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to `primary-ip list` would only return the first page of the results which by default is 50 items. By using `.AllWithOpts` instead of `.List`, hcloud-go automatically fetches all pages for us.
LKaemmerling
approved these changes
Nov 11, 2022
apricote
pushed a commit
that referenced
this pull request
Oct 19, 2023
On the FloatingIPClient List was used instead of AllWithOpts, which resulted in "list" only returning the first 50 entries. (Same as #415)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
hcloud primary-ip listwould only return the first page of the results which by default is 50 items. By using.AllWithOptsinstead of.List, hcloud-go automatically fetches all pages for us.