fix: send debug output to stderr #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabling debug output (`HCLOUD_DEBUG=true`), this was being
printed to stdout by default. If one was using the output of the
command in a script, this would break that usage.
By outputting to stderr, we can make sure that the "normal" output
still works as expected and can be used in subsequent steps.
For example:
export HCLOUD_DEBUG=true
IP=$(hcloud server ip hccm-dev-1)
ping $IP
samcday
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling debug output (
HCLOUD_DEBUG=true), this was being printed to stdout by default. If one was using the output of the command in a script, this would break that usage.By outputting to stderr, we can make sure that the "normal" output still works as expected and can be used in subsequent steps.
For example: