Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): add support for exposing routes to vswitch connection #504

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

apricote
Copy link
Member

@apricote apricote commented Jun 21, 2023

Feature was released today. This adds:

  • Showing the field in network describe (also for -o json)
  • Setting the field through flag on network create
  • Updating the setting through the command network expose-routes-to-vswitch

@apricote apricote self-assigned this Jun 21, 2023
Feature was released today. This adds:

- Showing the field in `network describe` (also for `-o json`)
- Setting the field through flag on `network create`
- Updating the setting through the command `network expose-routes-to-vswitch`
@apricote apricote marked this pull request as ready for review June 21, 2023 15:30
@apricote apricote requested a review from jooola June 21, 2023 15:30
Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we forgetting the update command ?

@apricote
Copy link
Member Author

Aren't we forgetting the update command ?

Instead of adding the field to hcloud network update I added the new command hcloud network expose-routes-to-vswitch. This way its easier to add some more documentation to it, as its a potentially dangerous option.

Previously we mostly added new subcommands for actions. The only subcommands the use the general "update" api endpoints are for managing labels. Do you think its easier for the user to understand if its part of the hcloud network update command?

@jooola
Copy link
Member

jooola commented Jun 22, 2023

Previously we mostly added new subcommands for actions. The only subcommands the use the general "update" api endpoints are for managing labels. Do you think its easier for the user to understand if its part of the hcloud network update command?

I think it's about being consistent, I would assume that if I have an update command, it will be consistent with the rest of the integrations. Either we document that the update command does not include all the fields, or we add multiple ways of updating such values.

@apricote
Copy link
Member Author

I added a note to the hcloud network update command to send users the right way.

@apricote apricote merged commit 339cee9 into main Jun 22, 2023
@apricote apricote deleted the expose-routes-to-vswitch branch June 22, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants