fix: removing last rule from firewall fails with invalid_input error #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Very nice catch!
Could you update the tests to check for an empty array? This line should have []hcloud.FirewallRule{} instead of nil: https://github.com/hetznercloud/cli/blob/main/internal/cmd/firewall/delete_rule_test.go#L39
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
=======================================
Coverage 58.78% 58.78%
=======================================
Files 179 179
Lines 6536 6536
=======================================
Hits 3842 3842
Misses 2087 2087
Partials 607 607 ☔ View full report in Codecov by Sentry. |
apricote
changed the title
apricote
approved these changes
Feb 13, 2024
phm07
pushed a commit
that referenced
this pull request
Apr 3, 2024
🤖 I have created a release *beep* *boop* --- ## [1.43.0](v1.42.0...v1.43.0) (2024-04-03) ### Features * allow deletion of multiple resources at once ([#719](#719)) ([3b896fe](3b896fe)) * improve missing argument error messages ([#711](#711)) ([e7f9e74](e7f9e74)) * **server:** allow JSON & YAML output in reset-password ([#716](#716)) ([373287b](373287b)), closes [#715](#715) ### Bug Fixes * removing last rule from firewall fails with invalid_input error ([#696](#696)) ([acab17c](acab17c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to delete last firewall rule, rule is
nullbut should be[], resulting in error messagehcloud firewall delete-rule --direction in --protocol tcp --source-ips '8.8.8.8/32' --port 443 f2b