Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow passing multiple args to server ssh command #729

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: allow passing multiple args to server ssh command #729

merged 2 commits into from
Apr 17, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Apr 11, 2024

Related to #711

Closes #728

@jooola jooola requested a review from a team as a code owner April 11, 2024 16:46
@jooola jooola mentioned this pull request Apr 11, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.92%. Comparing base (73579dd) to head (acc4854).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
+ Coverage   59.52%   59.92%   +0.40%     
==========================================
  Files         180      180              
  Lines        6510     6511       +1     
==========================================
+ Hits         3875     3902      +27     
+ Misses       2021     1991      -30     
- Partials      614      618       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apricote
Copy link
Member

Can we add some test cases for this command? It is pretty special in that it just spawns ssh, so I would like to make sure that it will keep working in the future.

@jooola
Copy link
Member Author

jooola commented Apr 11, 2024 •
edited
Loading

Not totally happy with how the test are right now, might need some more refactoring. Any ideas are welcome, also for the SSHPath() hack.

@apricote apricote requested a review from phm07 April 16, 2024 05:34
@phm07
Copy link
Contributor

phm07 commented Apr 17, 2024

Not totally happy with how the test are right now, might need some more refactoring. Any ideas are welcome, also for the SSHPath() hack.

Another idea would be to create a global var that contains the SSH path and change it during the tests, or to create an interface to wrap exec.Cmd and mock it.

@jooola jooola merged commit d98aee5 into main Apr 17, 2024
4 checks passed
@jooola jooola deleted the fix-ssh-variadic-command-args branch April 17, 2024 13:10
@hcloud-bot hcloud-bot mentioned this pull request Apr 17, 2024
Merged
apricote pushed a commit that referenced this pull request Apr 22, 2024
@hcloud-bot
chore(main): release 1.43.1 (#731)
22e3863 
🤖 I have created a release *beep* *boop*
---


## [1.43.1](v1.43.0...v1.43.1) (2024-04-19)


### Bug Fixes

* allow passing multiple args to server ssh command ([#729](#729))
([d98aee5](d98aee5)),
closes [#728](#728)
* creating firewall with rules not working correctly
([64aeb23](64aeb23))
* **firewall:** missing error when not setting port for tcp rule
([#734](#734))
([c5ad470](c5ad470))
* **firewall:** setting rules not working correctly
([da1b684](da1b684))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@BrewTestBot BrewTestBot mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phm07 phm07 phm07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hcloud server ssh <server> [command] is broken
3 participants
@jooola @apricote @phm07