refactor: redefintion and shadowing of builtin id cap #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update of golangci-lint to v1.62.0 discovered a redefinition of cap in our capability check. Furthermore, we are shadowing cap in certain places.
lukasmetzner
force-pushed
the
fix-redefines-builtin-id
branch
from
3fa4c71
to
02e55f6
Compare
|
You could have squeezed that one in the renovate upgrade PR, and merge it yourself, but that works too :) |
jooola
approved these changes
Nov 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
=======================================
Coverage 35.98% 35.98%
=======================================
Files 20 20
Lines 1848 1848
=======================================
Hits 665 665
Misses 1150 1150
Partials 33 33 ☔ View full report in Codecov by Sentry. |
lukasmetzner
added a commit
that referenced
this pull request
Nov 11, 2024
Update PR of golangci-lint to v1.62.0 discovered a redefinition of cap in our capability check. Furthermore, we are shadowing cap in certain places. Additionally, upgrade from v1.62.0 of golangci-lint (#774) can not be merged before this is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PR of golangci-lint to v1.62.0 discovered a redefinition of cap in our capability check. Furthermore, we are shadowing cap in certain places.
Additionally, upgrade from v1.62.0 of golangci-lint (#774) can not be merged before this is fixed.