Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ServerClient.RebuildWithResult to return root password #245

Merged
merged 2 commits into from
Mar 6, 2023
Merged

feat: add ServerClient.RebuildWithResult to return root password #245

merged 2 commits into from
Mar 6, 2023

Commits on Mar 6, 2023

  1. feat: add ServerClient.RebuildWithResult to return root password 

    The existing method Serverclient.Rebuild did not return the root
password and there was no way to add it without breaking API
compatibility.

Closes #244
    @apricote
    apricote committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    f93459d View commit details
    Browse the repository at this point in the history

  2. chore: cleanup comments for ServerClient.Delete(WithResult) 

    - Comment should start with the method name
- Deprecated methods should contain "^Deprecated: xx" in the
  comment
- References to other symbols should use square brackets
    @apricote
    apricote committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    f1845c0 View commit details
    Browse the repository at this point in the history