Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement actions waiter (#407) [Backport release-1.x] #433

Merged
merged 1 commit into from
May 6, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented May 6, 2024

Implement a simpler and more versatile waiting functions for actions.

Most use cases when waiting for actions is to return early if an action fails. If all actions must be waited until completion, the users should use the WaitForFunc function.

If the final actions objects are needed, the users should use the WaitForFunc function to store the final actions using the handleUpdate callback.

This deprecates the ActionClient.WatchOverallProgress and ActionClient.WatchProgress methods.

(cherry picked from commit 1e3fa70)

BEGIN_COMMIT_OVERRIDE
feat: implement actions waiter
END_COMMIT_OVERRIDE

Implement a simpler and more versatile waiting functions for actions.

Most use cases when waiting for actions is to return early if an action
fails. If all actions must be waited until completion, the users should
use the `WaitForFunc` function.

If the final actions objects are needed, the users should use the
`WaitForFunc` function to store the final actions using the
`handleUpdate` callback.

This deprecates the `ActionClient.WatchOverallProgress` and
`ActionClient.WatchProgress` methods.

(cherry picked from commit 1e3fa70)
@jooola jooola requested a review from a team as a code owner May 6, 2024 09:28
@jooola jooola requested a review from apricote May 6, 2024 09:34
@jooola jooola merged commit c4d8be8 into release-1.x May 6, 2024
3 checks passed
@jooola jooola deleted the backport-407-to-release-1.x branch May 6, 2024 09:38
@jooola jooola removed the request for review from apricote May 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant