Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update dependency pylint to v3 #307

Merged
merged 3 commits into from
Oct 4, 2023
Merged

deps: update dependency pylint to v3 #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3196d0
deps: update dependency pylint to v3
renovate[bot] Oct 2, 2023
0a43784
chore: upgrade config for pylint v3
jooola Oct 4, 2023
9888958
refactor: fix cyclic import
jooola Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions hcloud/servers/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
from ..floating_ips import BoundFloatingIP
from ..images import BoundImage, CreateImageResponse
from ..isos import BoundIso
from ..networks import BoundNetwork # noqa
from ..networks import Network # noqa
from ..placement_groups import BoundPlacementGroup
from ..primary_ips import BoundPrimaryIP
from ..server_types import BoundServerType
Expand All @@ -35,6 +33,7 @@
from ..images import Image
from ..isos import Iso
from ..locations import BoundLocation, Location
from ..networks import BoundNetwork, Network
from ..placement_groups import PlacementGroup
from ..server_types import ServerType
from ..ssh_keys import BoundSSHKey, SSHKey
Expand Down Expand Up @@ -131,6 +130,9 @@ def __init__(self, client: ServersClient, data: dict, complete: bool = True):

private_nets = data.get("private_net")
if private_nets:
# pylint: disable=import-outside-toplevel
from ..networks import BoundNetwork

private_nets = [
PrivateNet(
network=BoundNetwork(
Expand Down
4 changes: 1 addition & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,14 @@ jobs = 0
[tool.pylint.reports]
output-format = "colorized"

[tool.pylint.basic]
good-names = ["i", "j", "k", "ex", "_", "ip", "id"]

[tool.pylint."messages control"]
disable = [
"fixme",
"line-too-long",
"missing-class-docstring",
"missing-module-docstring",
"redefined-builtin",
"duplicate-code",
# Consider disabling line-by-line
"too-few-public-methods",
"too-many-public-methods",
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
],
"test": [
"coverage>=7.3,<7.4",
"pylint>=2.17.4,<2.18",
"pylint>=3,<3.1",
"pytest>=7.4,<7.5",
"mypy>=1.5,<1.6",
"types-python-dateutil",
Expand Down