Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Error handling background color in HTML snippet browser when changing theme #524

Open
KseniyaKerzhner opened this issue Jul 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@KseniyaKerzhner
Copy link

KseniyaKerzhner commented Jul 3, 2024

Summary

When HTML snippet is opened, when switching from light to dark theme, the browser background becomes dark and the text is not visible. By default, the text in HTML is always black if there are no styles.
When the page is refreshed, the background is light again.
I suggest to make it so that the browser background in HTML snippets does not change and is always white.

The error is reproduced only when opening from the light theme for the first time or after reloading from the light theme.
If you just switch from dark to light theme, there is no error.

The JS snippet handles it correctly, the background in the dark theme is always dark because it's a console and the font is automatically adjusted there.

01.07.2024.mp4

Reproduction steps

1. Authorize and the light theme must be enabled
2. Open an HTML snippet that contains the code
3. Switch the theme to dark
4. Click refresh page

Expected result

When switching to a dark theme, the browser background remains white

image

Actual result

When you switch to a dark theme, the browser background turns black

image

Browsers

Chrome

OS

Windows

@KseniyaKerzhner KseniyaKerzhner added the bug Something isn't working label Jul 3, 2024
@KseniyaKerzhner KseniyaKerzhner changed the title Bug: Ошибка обработки цвета бэкграунда в браузере HTML снипета при смене темы Bug: Error handling background color in HTML snippet browser when changing theme Jul 8, 2024
@Mehdi-Messaadi
Copy link
Contributor

Hello!
I'd like to take this issue on, please!
I'll soon create a Pull Request with my changes.

Mehdi-Messaadi added a commit to Mehdi-Messaadi/runit that referenced this issue Jul 22, 2024
dzencot added a commit that referenced this issue Jul 23, 2024
…ml-snippet-dark-theme

[#524]: fixed HTML snippet browser background color in dark theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants