Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i8n): compatibility with og:locale #84

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

curbengh
Copy link
Contributor

A change introduced in hexojs/hexo#3808, og:locale Open Graph tag only accepts "language_TERRITORY" format.

Since "language_TERRITORY" breaks multilingual support, user should instead use "language-TERRITORY" format which is automatically transformed to "language_TERRITORY" in open_graph() helper.

However, "language-TERRITORY" still breaks multilingual support for non-ZH users, this PR fixes that.

See official list (by Facebook; Hexo only checks the length, not the value itself) of supported locales.

@curbengh curbengh requested a review from a team December 10, 2019 03:08
@curbengh curbengh requested review from a team and removed request for a team August 9, 2020 09:10
@curbengh curbengh merged commit 0c611b9 into hexojs:master Aug 10, 2020
@curbengh curbengh deleted the og-locale branch August 10, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants