perf(external_link): update regexp #4467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
isExternalLink()
has a shorthand optimization for absolute link:https://github.com/hexojs/hexo-util/blob/fe64888f28acaa77f26eab04e7d358c6e6029967/lib/is_external_link.js#L19
Then I think why can't we exclude relative link directly in the
rATag
to avoid extraisExternalLink()
andRegExp#test
? So here is the PR.How to test
Screenshots
Pull request tasks