Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix some typos #1017

Merged
merged 1 commit into from
Sep 5, 2024
Merged

refactor: fix some typos #1017

merged 1 commit into from
Sep 5, 2024

Conversation

mikavilpas
Copy link
Contributor

I realize typo fixes are neither crucial or a popular contribution, but I was reading the code and came across these and wanted to offer them as a mini improvement anyway 🙂

Copy link

stackblitz bot commented Sep 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Sep 5, 2024

⚠️ No Changeset found

Latest commit: 70092e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 5:57am

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy, thanks for fixing these. I definitely care about typos 😬

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (386da70) to head (70092e0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files          89       89           
  Lines       10973    10973           
  Branches     1113     1113           
=======================================
  Hits         8361     8361           
  Misses       2605     2605           
  Partials        7        7           
Flag Coverage Δ
unittests 76.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1017
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1017
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1017

commit: 70092e0

@mrlubos mrlubos merged commit b6106a6 into hey-api:main Sep 5, 2024
17 checks passed
@mikavilpas mikavilpas deleted the typo-fixes branch September 5, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants