Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TanStack Query plugin using missing import for infinite query #1195

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Oct 25, 2024

Closes #1165

Copy link

stackblitz bot commented Oct 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:41am

@mrlubos mrlubos marked this pull request as ready for review October 25, 2024 11:41
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 753643f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.15%. Comparing base (15acb33) to head (753643f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../src/plugins/@tanstack/query-core/plugin-legacy.ts 14.28% 6 Missing ⚠️
packages/openapi-ts/src/openApi/index.ts 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
- Coverage   73.16%   73.15%   -0.02%     
==========================================
  Files         126      126              
  Lines       17836    17833       -3     
  Branches     1720     1720              
==========================================
- Hits        13049    13045       -4     
- Misses       4784     4785       +1     
  Partials        3        3              
Flag Coverage Δ
unittests 73.15% <30.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1195
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1195
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1195

commit: 753643f

@mrlubos mrlubos merged commit 598028a into main Oct 25, 2024
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/tanstack-query-missing-import branch October 25, 2024 11:48
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type is used in the react query gen, but is not imported there, which leads to a TS error
1 participant