Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-6: switch off MySQL initialize-insecure option #7

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

hfagerlund
Copy link
Owner

Resolves issue #6 - (ie. Laravel Sail no longer displays warning on startup).

Changed

  • docker-compose.yml - Switch off the --initialize-insecure option
  • .env - Assign (new) MySQL service password (shown below - no PR req'd since not committed to repo)

.env: 16 -
DB_PASSWORD=password -> DB_PASSWORD={new_password_here}

* Changed in combination with assignment of (new) MySQL service password (DB_PASSWORD) in .env file
 * Result: Laravel Sail no longer displays warning on startup
@hfagerlund hfagerlund self-assigned this Apr 19, 2023
@hfagerlund hfagerlund added this to the Fix Sail up warnings milestone Apr 19, 2023
@hfagerlund hfagerlund merged commit 82c5522 into main Apr 19, 2023
@hfagerlund hfagerlund deleted the mysql_initialize-insecure branch April 19, 2023 20:27
Copy link
Owner Author

@hfagerlund hfagerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
Reverted in PR #11.

(And the 'switch-off-initialize-insecure-option' warning does not recur.)

hfagerlund added a commit that referenced this pull request Apr 23, 2023
* Generate model and migration using:
$ ./vendor/bin/sail artisan make:model -m Question
$ ./vendor/bin/sail artisan make:model -m Hint
* Create foreign key relationship between tables ('question_id' on the 'hints' table references the 'id' column on the 'questions' table)
*     Reverting 068fe29 and using it in combination with the (new) .env file (from PR #7 - ie. with the changed/new password) were required in order for the following to work:

$ ./vendor/bin/sail artisan migrate
hfagerlund added a commit that referenced this pull request Apr 23, 2023
* Generate model and migration using:
$ ./vendor/bin/sail artisan make:model -m Question
$ ./vendor/bin/sail artisan make:model -m Hint
* Create foreign key relationship between tables ('question_id' on the 'hints' table references the 'id' column on the 'questions' table)
*     Reverting 068fe29 and using it in combination with the (new) .env file (from PR #7 - ie. with the changed/new password) were required in order for the following to work:

$ ./vendor/bin/sail artisan migrate
hfagerlund added a commit that referenced this pull request Apr 24, 2023
* Reverting 068fe29 and using it in combination with the (new) .env file (from PR #7 - ie. with the changed/new password) were required in order for the following to work:
$ ./vendor/bin/sail artisan migrate
(as mentioned in PR #11)
hfagerlund added a commit that referenced this pull request Apr 24, 2023
* Reverting 068fe29 and using it in combination with the (new) .env file (from PR #7 - ie. with the changed/new password) were required in order for the following to work:
$ ./vendor/bin/sail artisan migrate
(as mentioned in PR #11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant