Skip to content

Commit

Permalink
revert test skip introduced for #239 (#244)
Browse files Browse the repository at this point in the history
  • Loading branch information
mutricyl authored Jul 13, 2024
1 parent ae0bd2b commit fcd41c2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-pandas-pre.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
python-version: ["3.10", "3.11", "3.12"]
numpy: ["numpy>=1.20.3,<2.0.0", "numpy==2.0.0.rc2"]
pandas: ["pandas>=3.0.0"]
pint: ["pint==0.24"]
pint: ["pint>=0.24"]

runs-on: ubuntu-latest

Expand Down
2 changes: 1 addition & 1 deletion pint_pandas/testsuite/test_issues.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def test_reductions(self, reduction):
t = self._timeit(getattr(s, reduction)).to("ms")

if t > 0:
assert tp <= 5 * t
assert tp <= 10 * t


def test_issue_86():
Expand Down
20 changes: 1 addition & 19 deletions pint_pandas/testsuite/test_pandas_extensiontests.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,7 @@ def dtype():


_base_numeric_dtypes = [float, int]
if pandas_version_info <= (3, 0, 0):
_all_numeric_dtypes = _base_numeric_dtypes + [np.complex128]
else:
# work around to make test pass in the context of GH #239
# complex induce NumpyExtensionArray that are not managed by
# latest version of pandas.core.algorithms.take
# https://github.com/pandas-dev/pandas/issues/59177
_all_numeric_dtypes = _base_numeric_dtypes
_all_numeric_dtypes = _base_numeric_dtypes + [np.complex128]


@pytest.fixture(params=_all_numeric_dtypes)
Expand Down Expand Up @@ -321,17 +314,6 @@ def test_insert_invalid(self):
def _get_expected_exception(
self, op_name: str, obj, other
): # -> type[Exception] | None, but Union types not understood by Python 3.9
if op_name in [
"__radd__",
"__rsub__",
"__rmul__",
"__rtruediv__",
"__rpow__",
] and pandas_version_info >= (3, 0, 0):
pytest.skip(
f"ongoing issue with pandas >=3 with {type(obj).__name__} that does not support {op_name}. GH #239"
)
return TypeError
if op_name in ["__pow__", "__rpow__"]:
return DimensionalityError

Expand Down

0 comments on commit fcd41c2

Please sign in to comment.