use packaging.version.parse instead of StrictVersion for version checking #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #872, maybe we can fix both things at the same time. |
|
it's now in |
I think so |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 12, 2019
926: use packaging.version.parse instead of StrictVersion for version checking r=hgrecco a=keewis fixes #872 `distutils.version.StrictVersion` cannot parse numpy development versions like `1.19.0.dev0+578f4e7`. `LooseVersion` is able to parse the version, but it compares ```python >>> LooseVersion("1.19.0.dev0+578f4e7") < LooseVersion("1.19") False ``` Using `pkg_resources.extern.packaging.version.parse` instead makes this work as expected. Since `setup.py` requires `setuptools`, I think it being installed is a reasonable assumption? Co-authored-by: Keewis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #872
distutils.version.StrictVersioncannot parse numpy development versions like1.19.0.dev0+578f4e7.LooseVersionis able to parse the version, but it comparesUsing
pkg_resources.extern.packaging.version.parseinstead makes this work as expected. Sincesetup.pyrequiressetuptools, I think it being installed is a reasonable assumption?