-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss: 2021: Inclusion of new languages in :common
set
#2848
Comments
:common
default distributable:common
set
Looking at some language rankings (see below), it seems like good candidates for adding would be As far as removal goes, definitely Additionally, the list of config languages ( Tiobe Indexhttps://www.tiobe.com/tiobe-index
StackOverflow Survey 2020https://insights.stackoverflow.com/survey/2020#technology-programming-scripting-and-markup-languages
GitHub Octoverse 2019https://octoverse.github.com/#top-languages-over-time
|
Thanks for the thoughts!
Lua was specifically added for "fun" not popularity, but perhaps that was a wrong idea. :-) A little bit of my opinion sneaking into the list. :-)
Agree, they are definitely more systemy... but we've kind of always had them and they aren't large... so I feel like we'd need a good reason (or lot of agreement to rip them out). I might disagree on I also wonder if perhaps we should have a size target in advance for "how large can our default set be" vs just sticking things in and then saying "feels right" at some point. :-) Currently 37kb gzipped still feels pretty tiny to me. |
node ./tools/build.js -t browser :common r vbnet powershell groovy matlab dart scala haskell julia
highlight.js : 333694 bytes
highlight.min.js : 136067 bytes
highlight.min.js.gz : 44664 bytes Only adds (without any removals)... still not bad on the gziped size. I'd also be game if we made the future downloader more flexible as in able to check off categories... so perhaps you just requested:
And say that gave you common + web (http, apache, etc) + functional (functional langauges), etc... this is harder though if we have more and more combinations because then we have to build and put them all on the CDN, etc... more moving pieces, more potential of breakage, etc. |
@egor-rogov @allejo Any objections to dropping any of these from :common with v11? Also my vote would be:
x86asm is one of the larger syntaxes, so I'm not a fan of adding it to the default bundle. |
No particular objections (for any of those suggestions) |
@joshgoebel Reading through the comments again, I do agree that Otherwise, the plan sounds good. 👍 |
-1 on removing |
So then:
No objection to keeping |
Closing per above conclusions. |
…mmon Fully resolves highlightjs#2848. Related highlightjs#2558.
…mmon Fully resolves highlightjs#2848. Related highlightjs#2558.
Current decision:
Wanted to open a new discussion for v11 (or perhaps even just 2021) regarding whether any new languages should be added to our "common" set... and hence also the default CDN distributable
highlight.min.js
. We can of course add at anytime (since adding is not a breaking change) but I think it's helpful to have a yearly review.Removing grammars however would be a breaking change so any removals will by necessity wait until v11.
There is no real criteria other than the nebulous and vague "common"... which I've always taken as a loose synonym for "popular", "frequently used", "people have heard of it", etc...
The 2019 discussion on this: #2206
What we considered adding last time but didn't:
What almost got cut last time:
Things we should probably add for parity:
The current full :common list:
The text was updated successfully, but these errors were encountered: