Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax for Solidity 0.8.4 #40

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Update syntax for Solidity 0.8.4 #40

merged 1 commit into from
Apr 22, 2021

Conversation

haltman-at
Copy link
Collaborator

Syntax updates for Solidity 0.8.4:

  1. I've promoted revert from a builtin to a keyword. Really it's both now, but I figure keyword wins?
  2. I've added error as a keyword.
  3. I've added the new builtin bytes.concat.
  4. I was going to add hex strings in assembly, but it turns out we actually already had those even though they apparently didn't exist previously! :P

@haltman-at haltman-at requested a review from frangio April 21, 2021 21:19
@joshgoebel
Copy link
Member

joshgoebel commented Apr 21, 2021

Reminder: lexemes has been deprecated for quite a while and soon to be removed with v11. Use keywords.$pattern instead.

@haltman-at
Copy link
Collaborator Author

I was unaware of that, thanks. So I guess we'll have to change that soon. But I'm going to skip doing that on this PR since this is just a quick syntax update that I also ideally want to get out quickly, and we can handle that problem together with the other transition stuff either in #37 or a separate PR?

@joshgoebel
Copy link
Member

It was just a heads up, wasn't expecting you to merge it with this work.

Copy link
Collaborator

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haltman-at haltman-at merged commit 894787f into master Apr 22, 2021
@haltman-at haltman-at deleted the updates-084 branch April 22, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants