Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working support for Jakarta version of XJC #129

Closed
wants to merge 1 commit into from
Closed

Working support for Jakarta version of XJC #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ant/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<parent>
<groupId>org.jvnet.jaxb2_commons</groupId>
<artifactId>jaxb2-basics-project</artifactId>
<version>0.12.1-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
</parent>
<dependencies>
<dependency>
Expand All @@ -17,8 +17,8 @@
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.sun.activation</groupId>
<artifactId>javax.activation</artifactId>
<groupId>jakarta.activation</groupId>
<artifactId>jakarta.activation-api</artifactId>
Copy link

@lukasj lukasj Sep 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for activation v 2.0.x, I'd avoid changing this to an API artifact as it can do more harm than good - com.sun.activation may conflict with jakarta.activation on JPMS. This change is fine with activation-api 2.1.0 (currently RC1); an implementation is ie angus-activation, currently at 1.0.0-M1.

For now, my recommendation is to use com.sun.activation:jakarta.activation:2.0.1 if one needs stable version

Copy link
Author

@sebersole sebersole Sep 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked with your suggestion. But at least for my build, it worked with what I had also.

Copy link

@lukasj lukasj Sep 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, in "classpath-only" cases it works Try to put the JAXB RI and its dependencies + jakarta.activation-api on the module path. Or simply just the API and Impl (API jar contains references to classes which are not available in the API jar itself, so whoever tries to use it, may get NoClassDefFoundError at some point, and both jars contain same API packages - split package problem) - in general not a big deal for jaxb as such; it's bigger problem for projects built on top of it or using it.

<scope>provided</scope>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion basic/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<parent>
<groupId>org.jvnet.jaxb2_commons</groupId>
<artifactId>jaxb2-basics-project</artifactId>
<version>0.12.1-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
</parent>
<dependencies>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion plugins/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.jvnet.jaxb2_commons</groupId>
<artifactId>jaxb2-basics-project</artifactId>
<version>0.12.1-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
</parent>
<dependencies>
<dependency>
Expand Down
12 changes: 6 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<groupId>org.jvnet.jaxb2_commons</groupId>
<artifactId>jaxb2-basics-project</artifactId>
<packaging>pom</packaging>
<version>0.12.1-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
<name>JAXB2 Basics - Project</name>
<url>https://github.com/highsource/jaxb2-basics</url>
<description>JAXB2 Basics is a part of JAXB2 Commons project which implements plugins and tools for JAXB 2.x reference implementation.</description>
Expand Down Expand Up @@ -138,7 +138,7 @@
</profiles>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<jaxb.version>3.0.0-M4</jaxb.version>
<jaxb.version>3.0.2</jaxb.version>
<activation.version>1.2.0</activation.version>
<maven-jaxb2-plugin.version>0.14.0</maven-jaxb2-plugin.version>
<cxf-codegen-plugin.version>3.2.4</cxf-codegen-plugin.version>
Expand Down Expand Up @@ -212,7 +212,7 @@
<dependency>
<groupId>jakarta.xml.bind</groupId>
<artifactId>jakarta.xml.bind-api</artifactId>
<version>3.0.0-RC3</version>
<version>3.0.1</version>
</dependency>
<dependency>
<groupId>org.glassfish.jaxb</groupId>
Expand All @@ -230,9 +230,9 @@
<version>${jaxb.version}</version>
</dependency>
<dependency>
<groupId>com.sun.activation</groupId>
<artifactId>javax.activation</artifactId>
<version>${activation.version}</version>
<groupId>jakarta.activation</groupId>
<artifactId>jakarta.activation-api</artifactId>
<version>2.0.1</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now 2.1.0 already exists.

</dependency>
<!-- JUnit -->
<dependency>
Expand Down
6 changes: 3 additions & 3 deletions runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<parent>
<groupId>org.jvnet.jaxb2_commons</groupId>
<artifactId>jaxb2-basics-project</artifactId>
<version>0.12.1-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
</parent>
<dependencies>
<dependency>
Expand All @@ -27,8 +27,8 @@
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.sun.activation</groupId>
<artifactId>javax.activation</artifactId>
<groupId>jakarta.activation</groupId>
<artifactId>jakarta.activation-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion testing/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<parent>
<groupId>org.jvnet.jaxb2_commons</groupId>
<artifactId>jaxb2-basics-project</artifactId>
<version>0.12.1-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
</parent>
<dependencies>
<dependency>
Expand Down
6 changes: 3 additions & 3 deletions tools/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<parent>
<groupId>org.jvnet.jaxb2_commons</groupId>
<artifactId>jaxb2-basics-project</artifactId>
<version>0.12.1-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
</parent>
<dependencies>
<dependency>
Expand Down Expand Up @@ -42,8 +42,8 @@
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.sun.activation</groupId>
<artifactId>javax.activation</artifactId>
<groupId>jakarta.activation</groupId>
<artifactId>jakarta.activation-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down