Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KiCost Value field case sensitive? #561

Open
craigarno opened this issue Mar 13, 2024 · 1 comment
Open

KiCost Value field case sensitive? #561

craigarno opened this issue Mar 13, 2024 · 1 comment

Comments

@craigarno
Copy link

craigarno commented Mar 13, 2024

Compare output .xlsx lines
row42 & row49 - R1, R2, R26, R27 against R10, R14. The only difference is 100k vs 100K.
image

row50 & row52 - R11, R15 against R18. The difference is 10K vs 10k
image

There are two of us working on the design. We have slightly different styles for entering data. This will continue to happen.

Is there a reason for making Value case sensitive? Much of the industry (and many Windows users) assume upper and lower case represent the same values. A PCB vendor's automation [PcbFabExpress] balked at these as "Identical Entries". And there is the issue of "order time" with these "identical parts" existing on two separate lines. With these use cases in mind, it might make more sense to combine both cases as the same part.

Please consider treating, or at least giving the option to treat, the value field as case-insensitive, so the parts will be combined in KiCost .xlsx output.

Issue / Problem report

  1. kicost --version
    KiCost v1.1.18

  2. Write the command used to call KiCost (or the graphical interface configuration);
    kicost -w -i "bom.xml" --eda kicad

  3. One BoM to reproduce the error (with the EDA version).

set-soft added a commit that referenced this issue Mar 22, 2024
@set-soft
Copy link
Collaborator

Hi @craigarno !

I think you are right, KiCost shouldn't make "100K" and "100k" different.

The above patch solves the issue. But IMHO the problem is much deeper. What about 100k vs 100 k? And about 0.1 uF vs 100 nF. Higher level tools, like KiBot can handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants