Too many failing builds #115
Comments
|
No cache, excepting maybe for maven libs, but I don't think it's related |
|
For somereason the error is from before my fixes for example this shouldnt happen anymore as I removed those expect calls in templates so dont know how it still does it. Lemme try to replicate this locally |
|
It turns out that proctrator is conflicting with chrome 91. |
|
@mshima but not for all builds I think, todays builds are running with some failures like I mentioned above |
|
@deepu105 the build you mentioned is before your PR. The correct is https://github.com/hipster-labs/jhipster-daily-builds/runs/2742805106. |
|
ah shit sorry |
|
anyway we need to work on this so i'm putting a bounty on this |
|
also should we switch to cypress for some tests instead of protractor ? |
|
@deepu105 : I mixed both, protractor for default builds, cypress for JDL |
|
@deepu105 you fixed on react side with jhipster/generator-jhipster@11dfed8#diff-c14159cc6cbb565f01325eed42e2932a5c0fe58c47a93ed84bea30fa41dcfa6c. Should be applied to angular and vue? |
|
I have no idea why it was added. Ideally it shouldn't be there as its a bad
practice to do expect in page objects IMO
…On Sat, 5 Jun 2021, 2:16 pm Marcelo Shima, ***@***.***> wrote:
@deepu105 <https://github.com/deepu105> you fixed on react side with
***@***.***
#diff-c14159cc6cbb565f01325eed42e2932a5c0fe58c47a93ed84bea30fa41dcfa6c
<jhipster/generator-jhipster@11dfed8#diff-c14159cc6cbb565f01325eed42e2932a5c0fe58c47a93ed84bea30fa41dcfa6c>
.
Should be applied to angular and vue?
Any clue why this was required?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#115 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIOKF6BDFIDOPASDIR2OQLTRIISVANCNFSM46CNRD4A>
.
|
|
I've deployed a workaround at jhipster/generator-jhipster#15227. Fix is merged but not released yet: https://bugs.chromium.org/p/chromium/issues/detail?id=1205107&start=300Upstream We should revert the workaround once the fix is released. |
|
Doesnt removing the expect checks in the page objects work? IMO they should
be removed as they dont server any purpose other then verifying if
protractor can input text to field and its not our responsibility to check
that. So we should remove those checks any way
Thanks & Regards,
Deepu
…On Mon, Jun 7, 2021 at 4:21 PM Marcelo Shima ***@***.***> wrote:
I've deployed a workaround at jhipster/generator-jhipster#15227
<jhipster/generator-jhipster#15227>.
Fix is merged but not released yet:
https://bugs.chromium.org/p/chromium/issues/detail?id=1205107&start=300Upstream
protractor issue: angular/protractor#5519
<angular/protractor#5519>
We should revert the workaround once the fix is released.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#115 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIOKF4A5O3G4G4GEMGUCE3TRTIYLANCNFSM46CNRD4A>
.
|
|
Not sure, but if I remember well, these additional checks were there to fix the random failures we got in the past |
|
Still some errors with React + i18n :
|
|
My investigation led me to jhipster/generator-jhipster@24e0894#diff-86124b7420820701b49181ce2aa6a3cb0dd3731cea2937e32311ae19b7393cf5 and specially at:
It explains the NPE in the backend, which could be fixed by something like: private String getLangKey(User user) {
return Optional.ofNullable(user.getLangKey()).orElse("en");
}Anyway, the failures are still there, as it concerns the front part. |
|
I made a PR. It should fix the React builds
Thanks & Regards,
Deepu
…On Fri, Jun 11, 2021 at 10:16 AM Pascal Grimaud ***@***.***> wrote:
My investigation led me to ***@***.***
#diff-86124b7420820701b49181ce2aa6a3cb0dd3731cea2937e32311ae19b7393cf5
<jhipster/generator-jhipster@24e0894#diff-86124b7420820701b49181ce2aa6a3cb0dd3731cea2937e32311ae19b7393cf5>
and specially at:
[image: image]
<https://user-images.githubusercontent.com/9156882/121654133-b2994f00-ca9d-11eb-971a-6a7de5e687e3.png>
It explains the NPE in the backend, which could be fixed by something like:
private String getLangKey(User user) {
return Optional.ofNullable(user.getLangKey()).orElse("en");
}
Anyway, the failures are still there, as it concerns the front part.
Can I let you have a look @deepu105 <https://github.com/deepu105> ? Not
sure I can solve the React part.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#115 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIOKF5G4MUUM4DXYIMFKMDTSHA6JANCNFSM46CNRD4A>
.
|
|
Everything is OK now ! |
|
I think @mshima and you also fixed some stuff right? So we should share the bounty |
|
may be we can each claim 100 |
|
Just added a new label, to increase the bounty. |
|
why 400 is there another person who worked on this apart form the 3 of us? |
Nice find, I was thinking the problem were sass builds not i18n. For reference the PR that fixed some builds is jhipster/generator-jhipster#15245. I am planning to add cache to reduce random failures soon. |
|
@mshima please claim 200 for your PR |
|
@deepu105 I am ok to split 300 in 3. |
|
Seems like he doesn't want to claim, but I think he should 😉 |
|
here is my part https://opencollective.com/generator-jhipster/expenses/42841 |
|
@deepu105 : approved |
|
@pascalgrimaud half bounty claimed https://opencollective.com/generator-jhipster/expenses/42842 |
|
@mshima : approved |
I was looking into failing builds after the recent react migrations jhipster/generator-jhipster#15191 and jhipster/generator-jhipster#15106 and found that there are many other failing builds as well with weird errors
Many failures seems to be during e2e tests. The angular protractor e2e tests are also failing and the above migrations havent touched those so it needs investigation. Also the React e2e were fixed in recent commits but the repo here seems to use old code anyway. @pascalgrimaud is there some sort of cache here?
Overall I might need more help here @pascalgrimaud @DanielFran @mshima @SudharakaP
The text was updated successfully, but these errors were encountered: