Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jasmine-auto-spies: Updated to use jasmine-core v5 #78

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

jpgoelz
Copy link
Contributor

@jpgoelz jpgoelz commented Aug 27, 2023

updated devDependency and peer dependencies to include latest jasmine version

fix #76

updated devDependency and peer dependencies to include latest jasmine version

fix hirezio#76
@similar-code-searcher
Copy link

Similar files are

@shairez
Copy link
Member

shairez commented Aug 29, 2023

Looks like pnpm lockfile is not committed

Can you please run pnpm locally and commit the lock file?

Thanks

updated devDependency and peer dependencies to include latest jasmine version

fix hirezio#76
@jpgoelz
Copy link
Contributor Author

jpgoelz commented Aug 30, 2023

Right, fixed that.

@shairez shairez merged commit 1096209 into hirezio:master Aug 31, 2023
3 checks passed
@shairez
Copy link
Member

shairez commented Aug 31, 2023

Thanks @jpgoelz !

@shairez
Copy link
Member

shairez commented Aug 31, 2023

@all-contributors please add @jpgoelz for maintenance

@allcontributors
Copy link
Contributor

@shairez

I've put up a pull request to add @jpgoelz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make jasmine-auto-spies compatible with jasmine-core 5
2 participants