Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cost constants #4

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Update cost constants #4

merged 2 commits into from
Nov 16, 2021

Conversation

reedrosenbluth
Copy link

Update the cost constants based on latest benchmarking data

Copy link

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Reed

@diwakergupta
Copy link
Member

Is this the final final pass on costs? I noticed that stacks-network/clarity-benchmarking#27 is closed but some functions still have very close but different costs (e.g. pow vs. sqrti)

Besides that, LGTM.

@kantai
Copy link

kantai commented Nov 16, 2021

Yes -- I'll go through and smooth these costs out now.

Copy link
Member

@diwakergupta diwakergupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diwakergupta diwakergupta merged commit f48d74b into draft/sip-012 Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants