Add ECIES encryption to putFile/getFile #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate key in getFile/putFile
…2), and fix randomBytes call
…n the decrypted response
|
|
|
Awesome @kantai ! Can't wait to try this out! |
Closed
larrysalibra
added a commit
that referenced
this pull request
Oct 9, 2017
larrysalibra
added a commit
that referenced
this pull request
Oct 9, 2017
|
beautiful @kantai
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using the AppPrivateKey to perform encryption and decryption of data stored using putFile/getFile.
This adds
encryptanddecryptboolean parameters toputFileandgetFile, respectively. These parameters default to false.This is an implementation of ECIES (see wiki), which uses the
cryptoandellipticlibraries --ellipticwas already an explicit dependency, andcryptowas an implicit dependency (though one that was already getting used explicity for getRandomBytes), so this shouldn't change our library dependency tree.