Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New config for Lenovo ThinkPad L390 i7-8565U #685

Merged

Conversation

bekliev
Copy link
Contributor

@bekliev bekliev commented May 14, 2019

Accordingly to this guideline for config files, I'm answering by their order:

  1. This config is based on Lenovo U41-70.xml config file, cause of write and reads I think. Any other of ThinkPad line configs didn't work for my laptop.
  2. Repeating: based on Lenovo U41-70.xml config.
  3. This config doesn't require any modifications - just dropdown -> find it in the list -> Press Apply => and it will work.

Changes to base config:

  1. Changed threshold of starting temperatures to be matched with system settings untill 68 degrees works as system fan set up. But from 68+ degrees fan set up to 85%, and after 90+ degrees set to 100%. Remark: system settings wasn't turn on the fan for even 85%, the max power was 72%.
  2. Set fan's Min speed to 255 and Max speed to 64 - to be 100% matched with Current fan speed indicator. I mean Target fan speed and Current fan speed is identical with these settings.
  3. Added CPU model to the config name, cause I thought it can cause different coolers - I don't know for sure.

1. This config is based on **Lenovo U41-70.xml** config file, cause of write and reads I think. Any other of ThinkPad lines didn't work for my laptop.
2. Based on **Lenovo U41-70.xml** config.
3. This config doesn't require any modifications - just dropdown -> find it in the list -> Press **Apply** => and it will work.

P.S. Added CPU model, cause I thought it can cause different coolers - I don't know for sure.
1. Added to the author field my surname.
2.  Changed temperature threshold to start temperatures have matched with system settings (only from 68 degrees fan set to 85%, af after 90 degrees set to 100% - system settings wasn't turn on for full-power).
@hirschmann
Copy link
Owner

Thank you very much for your effort.
I'd love to merge your pull request, but currently it doesn't pass all the unit tests:

Lenovo ThinkPad L390 i7-8565U config is not valid:

  • All up-threshold values must be lower than the critical temperature
    --> At least one up-threshold is higher than or equal to the critical temperature: 100

Expected: True
Actual: False

see: https://ci.appveyor.com/project/hirschmann/nbfc/builds/24547666/tests

Please fix this small issue and update the pull request, so I can merge it :)

1. Set "Poll interval" to 3 sec.
2. Deleted penult temperature threshold (very often temperature changes and fan is noisy)
3. Last temperature threshold's up set to 99 (below of Critical temperature)
@bekliev
Copy link
Contributor Author

bekliev commented Jun 5, 2019

Fixed the issue - can merge the PR

@hirschmann
Copy link
Owner

Thanks for the fix :)

@hirschmann hirschmann merged commit a6a8172 into hirschmann:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants