Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a working inheritance example #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebastianovide
Copy link

@vercel
Copy link

vercel bot commented May 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/leisim/docs/AYCLvtUdaxaRqpXZfCQoEbbse5Gg
✅ Preview: https://docs-git-fork-sebastianovide-inheritance-doc-leisim.vercel.app

@@ -7,5 +7,6 @@ To contribute, please open pull requests against the master branch.
You can run a local preview of the docs by running the following command in the project folder:

```
npm i docsify-cli -g
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
npm i docsify-cli -g

This is unnecessary, npx will install latest version temporarily.

Copy link
Member

@themisir themisir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and sorry for late response. While the addition of inheritance documentation is great, the contents are not descriptive enough or mostly consist of code snippet.

I would suggest adding a bit information regarding the inheritance and simplifying code snippet to introduce 2 classes (one inherits another one) and registering them. Or we could move that to examples section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simple inheritance broken
2 participants