Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/topic alias mapping #176

Merged
merged 2 commits into from
Jul 6, 2018
Merged

Bugfix/topic alias mapping #176

merged 2 commits into from
Jul 6, 2018

Conversation

SgtSilvio
Copy link
Member

Motivation

  • TopicAliasMapping did not assign the last topicAliasMaximum
  • MAY_OVERWRITE does not remove the overwritten topic

Changes

  • Fixed outgoing TopicAliasMapping
  • Added checks for TopicAliasUsage in PublishBuilder
  • Improved incoming TopicAliasMapping

@SgtSilvio
Copy link
Member Author

Do not merge before PR #174 is merged.
The base branch has to be changed to develop then.

@SgtSilvio SgtSilvio force-pushed the improvement/intmap-memory-consumption branch from 7603b7d to 7dbaba0 Compare July 6, 2018 15:52
@SgtSilvio SgtSilvio changed the base branch from improvement/intmap-memory-consumption to develop July 6, 2018 16:07
@SgtSilvio SgtSilvio changed the base branch from develop to improvement/intmap-memory-consumption July 6, 2018 16:11
@SgtSilvio SgtSilvio changed the base branch from improvement/intmap-memory-consumption to develop July 6, 2018 16:11
@SgtSilvio SgtSilvio merged commit b674c83 into develop Jul 6, 2018
@SgtSilvio SgtSilvio deleted the bugfix/topic-alias-mapping branch July 6, 2018 16:20
This was referenced Oct 12, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florian-Limpoeck Florian-Limpoeck Florian-Limpoeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtSilvio @Florian-Limpoeck