Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change param validation to verbose output #98

Conversation

hjorslev
Copy link
Owner

@hjorslev hjorslev commented Jun 1, 2024

Description

Fixes #97

Change the parameter validation to just show a verbose output if the application isn't found instead of throwing an error.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • ⚠️ [Security fix]
  • ♻️ [Refactor]
  • 🎉 [Feature]
  • ✨ Enhancement
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added Pester tests that covers the added cmdlets

@hjorslev hjorslev added Category-Module Pertaining to the module's functionality itself. Issue-Bug 🐛 Something's wrong! labels Jun 1, 2024
@hjorslev hjorslev self-assigned this Jun 1, 2024
@hjorslev hjorslev linked an issue Jun 1, 2024 that may be closed by this pull request
@hjorslev hjorslev changed the title Change param validation to warning Change param validation to verbose output Jun 1, 2024
@hjorslev hjorslev merged commit fd3b0e6 into master Jun 1, 2024
8 of 9 checks passed
@hjorslev hjorslev deleted the 97-unable-to-find-or-install-app-searching-by-id-or-name-fails branch June 1, 2024 17:41
@OTonGitHub
Copy link

Hi, so is there a way to verify if the app exists, or just relying on the results from steamcmd command.

@hjorslev
Copy link
Owner Author

hjorslev commented Jun 1, 2024

Relying on the results from SteamCMD (for now at least) so you are able to install it without being blocked by the parameter validation. Unless I find a better app list than the one Steam provides.

But ARK has for sure been in the app list via the Steam Web API. I can see that I use it as an example in Update-SteamApp.

@OTonGitHub
Copy link

It was, it's really weird, I think we need another way of fetching it or just see what's up with the SteamAPI. I will make a fork and try it out, is there a recommended way of testing this repo? I'd like to contribute if possible. Since its open source and if contributors are welcome.

@hjorslev
Copy link
Owner Author

hjorslev commented Jun 1, 2024

You are welcome to contribute!

I develop the commands locally and then when I write a corresponding Pester test (those are found in Tests\Unit). Then I create a PR that hopefully passes all the Pester tests. This is especially useful if reworking a cmdlet or something similar because then you can see if something breaks.

Only trouble as of now is that there are no SteamPS.psm1 file which would need to be created on your machine if you want to import the module locally. As of now SteamPS.psm1 are only created in the CI build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Module Pertaining to the module's functionality itself. Issue-Bug 🐛 Something's wrong!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find or install app, searching by ID or name fails.
2 participants