Usability Fixes #243
Merged
Usability Fixes #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented multi-select copy/paste. This basically takes the title, zconfig capabilities string & relative position of any selected actor, and uses CreateFromType and a new function "SetCapabilities" to re-create & inject the copied actor. Also respects max actor count (on paste)
Removed the enter restriction from input fields. Actors should be able to deal with nonsensical input (since they do this even when we hit enter). There is an ImGui issue that's been open for years that seeks to address this, maybe we can help it along to make this better: ocornut/imgui#701
Issue: we're hitting socket limits if we copy/paste a lot of nodes, so we should probably handle this "exceeded max actors" more gracefully. Or just increase the socket limit through the environment to some ridiculous amount (or at this point).
Also includes some fixes: