Require session middleware #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldfallen
force-pushed
the
require-session
branch
2 times, most recently
from
12f2957
to
49034ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 99.23% 99.31% +0.08%
==========================================
Files 7 8 +1
Lines 131 147 +16
==========================================
+ Hits 130 146 +16
Misses 1 1
Continue to review full report at Codecov.
|
dtaylor7
approved these changes
Aug 24, 2017
michaeldfallen
force-pushed
the
require-session
branch
from
12f2957
to
cb49865
Compare
michaeldfallen
force-pushed
the
require-session
branch
from
cb49865
to
3151730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the requireSession middleware. It is based off of #13 Simple Sessions.
It can be added to a step to enforce a session on that page. By default it redirects to
/(TODO: should be configurable with somestartpageproperty from Journey or infer from which step is of type Start?). You can override the behaviour by providing anoSessionHandlerto the journey function.CreateSession and DestroySession can be created using similar approaches.