Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web plugin is not registered correctly #330

Closed
0x3dev opened this issue May 3, 2022 · 5 comments
Closed

Web plugin is not registered correctly #330

0x3dev opened this issue May 3, 2022 · 5 comments

Comments

@0x3dev
Copy link

0x3dev commented May 3, 2022 •
edited
Loading

Hello, great work on the new web version.
But in the current form it's not registered in generated_plugin_registrant.dart

You need to add these changed to pubspec.yaml In image_cropper_for_web:

flutter:
      plugin:
        implements: image_cropper
        platforms:
          web:
            pluginClass: ImageCropperPlugin
            fileName: image_cropper_for_web.dart

EDIT: And also the WebUiSettings class is not exported from 'package:image_picker/image_picker.dart' currently

Thanks!
@hnvn
Copy link
Owner

hnvn commented May 3, 2022 •
edited
Loading

Thanks for your feedback, could you create a PR for it?

c-seeger added a commit to c-seeger/flutter_image_cropper that referenced this issue May 5, 2022
@c-seeger
fix: web platform hnvn#330
7faddf7
@c-seeger
Copy link
Contributor

c-seeger commented May 5, 2022

need it also prepared a PR

@c-seeger
Copy link
Contributor

c-seeger commented May 5, 2022

#332

hnvn added a commit that referenced this issue May 5, 2022
@hnvn
Merge pull request #332 from c-seeger/patch-1
0d91c24 
fix: web platform #330
@c-seeger
Copy link
Contributor

c-seeger commented May 5, 2022

❤️

@hnvn
Copy link
Owner

hnvn commented May 5, 2022

Released new version 2.0.1

@hnvn hnvn closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hnvn @0x3dev @c-seeger