Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to set the max bitmap generated size. Default to 0 #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add option to set the max bitmap generated size. Default to 0 #117

wants to merge 1 commit into from

Conversation

mde-pach
Copy link

Add the option maxBitmapSize to ImageCropper.cropImage that solve #108

@mde-pach
Copy link
Author

When the default value is 0, the maxBitmapSize is calculated in ucrop.

@hnvn
Copy link
Owner

hnvn commented Feb 1, 2020

I see the new property maxBitmapSize applied only for Android, why don't you move it to AndroidUiSettings?

@mde-pach mde-pach mentioned this pull request Feb 11, 2020
Open
@mde-pach mde-pach force-pushed the master branch 2 times, most recently from 85930d5 to 61cb7fb Compare March 12, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mde-pach @hnvn