Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] List of youth players does not get populated correct #2097

Closed
hvbun opened this issue Jun 28, 2024 · 8 comments
Closed

[BUG] List of youth players does not get populated correct #2097

hvbun opened this issue Jun 28, 2024 · 8 comments
Assignees
Labels
status: needs test might be fixed, needs test before closing
Milestone

Comments

@hvbun
Copy link

hvbun commented Jun 28, 2024

Describe the bug
When opening the youth tab, the list of players does not get populated correctly
Clicking on an empty line, will still show match details.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the youth tab
  2. See error

Screenshots
image

Platform information:

  • OS: [Windows / macOS / Linux]
  • Version 10 22H2 19045.4529

WORK ARROUND
Close the tab and open it again.
image

Copy link

Hey, thanks for opening your first issue! 🙂
Be sure to check out the wiki and the HT forum for support.

@wsbrenk
Copy link
Collaborator

wsbrenk commented Jun 29, 2024

if you can reproduce this error, please check the log file (in %APPDATA%/HO/logs) for error messages.
PLease upload these messages to this thread.

@hvbun
Copy link
Author

hvbun commented Jul 1, 2024

HO-1719851482.log

@wsbrenk wsbrenk added this to the 8.1 milestone Jul 1, 2024
@wsbrenk
Copy link
Collaborator

wsbrenk commented Jul 2, 2024

Thanks!

@wsbrenk wsbrenk self-assigned this Jul 2, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jul 2, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jul 2, 2024
# Conflicts:
#	src/main/resources/release_notes.md
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jul 2, 2024
wsbrenk added a commit that referenced this issue Jul 4, 2024
* #2094 youth scout comment sql error

* #2094 start 8.1 beta

* #2094 start 8.1 beta

* #2092 typo

* #2097 Fix MatchLineupTeam.examineSubstitution

* #2097 build.gradle git reporting of v8.1
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Jul 4, 2024
@hvbun
Copy link
Author

hvbun commented Jul 5, 2024

Running HO81 Beta, I still see the issue reported

image

The workaround closing and reopening the youth tab still works

image

@hvbun
Copy link
Author

hvbun commented Jul 5, 2024

Log file

HO-1720162498.log

Its is still a NPE, but in a different place.

@wsbrenk
Copy link
Collaborator

wsbrenk commented Jul 6, 2024

@hvbun thanks for reporting - there is a new beta. could you please test again? Hopefully the error is not again in another place but gone.

wsbrenk added a commit that referenced this issue Jul 6, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>

* Select suffix in extension block, as it then becomes immutable. (#2093)

* Fix issue with incorrect `-DEV` suffix in release.

The elvis operator returns the alternate branch if the condition is an empty string:

```groovy
groovy:000> "" ?: "pouet"
===> pouet

```

* Revert stable tag change to see if this is the root cause.

* Update version if GH action.

* Restore code.

* Re-create buid after manual delete of tags.

* Update release-dev.yml

Try using patched version to delete released version.

* Update release-dev.yml

Using the full SHA, as apparently this is required...

...although GH is even able to tell me which exact SHA to use!!  Also set the new option to true to trigger the deletion of non-draft.

* Update release-dev.yml

Latest version of GH action.

* Update release-dev.yml

* Update release-dev.yml

* #2094 youth scout comment sql error (#2095)

* #2094 youth scout comment sql error

* #2094 start 8.1 beta

* #2094 start 8.1 beta

* #2092 Fix skill tester rating predictions (#2098)

* #2092 Fix skill tester rating predictions

* #2092 typo

* #2097 Fix exception in youth player substitution (#2099)

* #2094 youth scout comment sql error

* #2094 start 8.1 beta

* #2094 start 8.1 beta

* #2092 typo

* #2097 Fix MatchLineupTeam.examineSubstitution

* #2097 build.gradle git reporting of v8.1

* #2097 Fix npe in MatchLineupTeam.initMinutesOfPlayersInSectors (#2101)

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>
@hvbun
Copy link
Author

hvbun commented Jul 8, 2024

it seems to load fine in 8.1 BETA r650
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Development

No branches or pull requests

2 participants