Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCP_NODELAY support #5

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add TCP_NODELAY support #5

merged 1 commit into from
Jun 20, 2024

Conversation

yassernasc
Copy link
Contributor

No description provided.

@yassernasc
Copy link
Contributor Author

I followed the node.js docs directive to not enable TCP_NODELAY by default at socket.connect and createServer but maybe it's a case to do the otherwise:

https://brooker.co.za/blog/2024/05/09/nagle.html
nodejs/node#906

Copy link
Contributor

@kasperisager kasperisager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👌

@kasperisager kasperisager merged commit 063ddb1 into main Jun 20, 2024
3 checks passed
@kasperisager kasperisager deleted the nodelay branch June 20, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants