Holiday accompanying coronation day #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
k1LoW
commented
Dec 19, 2018
| expect(@google_calendar.holiday?(date[0])).to eq true | ||
| end | ||
| end | ||
|
|
||
| it 'holidays_detailed.yml shoud have date of Google calendar' do | ||
| @gholidays.each do |date, name| | ||
| expect(@holidays_detailed.key?(date)).to eq true | ||
| expect(@holidays_detailed[date]['name']).to eq name | ||
| expect(@holidays_detailed[date]['name']).to eq(name).or eq('休日').or eq('休日（祝日扱い）') |
k1LoW
commented
Dec 19, 2018
| @@ -21,14 +21,15 @@ | |||
|
|
|||
| it 'Google calendar result should have date of holidays_detailed.yml' do | |||
| @span.each do |date| | |||
| next if date[0] == Date.new(2019, 10, 22) | |||
There was a problem hiding this comment.
テストに利用しているGoogle Calendarに10月22日の祝日がまだ来ていないため
|
@holiday-jp/maintainers こちら近日中にリリースをします。各ライブラリの修正準備をお願いします 🙇 |
k1LoW
added a commit
that referenced
this pull request
Dec 23, 2018
…on-day Holiday accompanying coronation day
k1LoW
added a commit
that referenced
this pull request
Dec 23, 2018
…on-day Holiday accompanying coronation day
This was referenced Dec 23, 2018
|
@holiday-jp/maintainers マージしました |
ne-sachirou
added a commit
to holiday-jp/holiday_jp-elixir
that referenced
this pull request
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
即位の礼に伴う祝日の修正です。
内閣府のページ に反映された段階でマージをしようと思います。