Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guideline testing instructions #213

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

selesse
Copy link
Contributor

@selesse selesse commented Jan 14, 2022

The testing instructions don't talk about how to test the integration between holiday and definitions. This updates the CONTRIBUTING doc to make sure it's easily discoverable by new contributors.

The testing instructions don't talk about how to test the integration
between holiday and definitions. This updates the CONTRIBUTING doc to
make sure it's easily discoverable by new contributors.
@ttwo32
Copy link
Member

ttwo32 commented Sep 4, 2022

@selesse Wow, Thank you for your contributing.
I think this helps others.
Thanks.:)

@ttwo32 ttwo32 merged commit d535317 into holidays:master Sep 4, 2022
@selesse selesse deleted the update-contribution-guide branch December 1, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants