Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion: optimize Scan() scientific scanning #127

Merged
merged 8 commits into from
Mar 16, 2023

Conversation

elee1766
Copy link
Contributor

@elee1766 elee1766 commented Mar 7, 2023

this pr has the following:

  1. the call to strings.SplitN in my original implementation is replaced with Index, and the function is changed to avoid the extra allocation
  2. makes the []byte variant properly parse scientific notation.
  3. adds pprof debug output to gitignore
  4. adds benchmark to bench the scan function

conversion.go Outdated Show resolved Hide resolved
conversion.go Outdated Show resolved Hide resolved
conversion_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #127 (0a3cbcb) into master (89e7a3b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         1508      1512    +4     
=========================================
+ Hits          1508      1512    +4     

@holiman holiman changed the title remove SplitN from scientific scanning conversion: optimize Scan() scientific scanning Mar 16, 2023
@holiman holiman merged commit c385c61 into holiman:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants